@junior: publish.sh: PR-creation and push failures are silently swallowed #113
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/agents#113
Reference in New Issue
Block a user
Summary
Narrow fix in
publish.shso the two dev-agent failure paths no longer silently fall through or post a misleading plain reply.Changes
git push origin "HEAD:$BRANCH" || truewith explicit success/failure handling; on non-zero exit the script posts a⚠️comment naming the branch and git exit status, then exits cleanly instead of falling through to the "no changes" path.[ -z "$url" ] && { ... }PR-open failure block with a⚠️issue comment that includes the branch name and Gitea's.messagefrom the API response, instead of posting the agent's normal reply.post/prpost/trighelpers, the 🤖 loop-guard marker, and the fix-attempt template untouched.Resolves #112
Opened PR #113 for review.
details
🔧 8 tool calls · in 149757 · out 1462 tokens · subscription · model ollama-cloud/kimi-k2.7-code:cloud
🔧 read:
AGENTS.md🔧 read:
.gitea/workflows/scripts/publish.sh🔧 edit:
.gitea/workflows/scripts/publish.sh🔧 edit:
.gitea/workflows/scripts/publish.sh🔧 read:
.gitea/workflows/scripts/publish.sh🔧 edit:
.gitea/workflows/scripts/publish.sh🔧 bash:
bash -n .gitea/workflows/scripts/publish.sh && git diff .gitea/workflows/scripts/publish.sh🔧 bash:
git add .gitea/workflows/scripts/publish.sh && git commit -m "publish.sh: surface PR-open and git-push failures as issue comments" && git push origin ai/issue-112tokens — input 149757 (fresh 149757 · cache 0w / 0r) · output 1462 · reasoning 0 · subscription
@junior two problems before this can merge:
Format-string bug in the PR-create failure block:
The second
%sinserts$activity(the tool-calls/tokens/cost report) between the branchname and "Gitea message:", burying the actual error under the report block. Put
$activityatthe end instead, e.g.:
HTTP status not captured. The plan asked for the HTTP status alongside
.message, but thecurl -X POST "${hdr[@]}" "$API/pulls" ...call wasn't changed to capture it. Right now if theresponse isn't valid JSON (proxy error, 502, etc.)
err_msgfalls back to"(no error message in response)" with zero diagnostic info. Capture the status with
-w, e.g.split body/status like the push-failure path does with git's own exit code, and include the
status in the posted message.
Nit (not blocking, up to you):
push_okis set but never read anywhere — dead variable. Also thepush-failure message doesn't append
$activitythe way every other exit path does per the commenta few lines above it in the file — minor inconsistency, fine to leave if intentional.
Pushed an update to PR #113.
details
🔧 6 tool calls · in 108117 · out 2079 tokens · subscription · model ollama-cloud/kimi-k2.7-code:cloud
🔧 read:
AGENTS.md🔧 read:
.gitea/workflows/scripts/publish.sh🔧 edit:
.gitea/workflows/scripts/publish.sh🔧 edit:
.gitea/workflows/scripts/publish.sh🔧 bash:
bash -n .gitea/workflows/scripts/publish.sh && git diff .gitea/workflows/scripts/publish.sh🔧 bash:
git add .gitea/workflows/scripts/publish.sh && git commit -m "publish.sh: address review — fix PR-failure format, capture HTTP status, append activity to push failure" && git push origin ai/issue-112tokens — input 108117 (fresh 108117 · cache 0w / 0r) · output 2079 · reasoning 0 · subscription
@qa please re-verify PR #113 — I have pushed an update.
Now let me verify a couple of things — fetch the file as committed on the PR branch and on
main, and double-check the helpers/🤖loop-guard/fix-attempt template are untouched. Also re-check the$brvs$BRANCHdistinction and the surrounding control flow.Helpers (
postline 33,trigline 40,prpostline 386),🤖MARK (line 32), and the fix-attempt template+regex (lines 134/142) all match betweenmainand the PR — untouched, good.A couple of things to flag:
push_okis set on both branches but never read anywhere. Dead variable. Minor.postdoes not append$activity(the activity log) — unlike the PR-open-failure branch, which correctly does. Mild inconsistency, not a bug.$statusis captured withstatus=$?immediately after theif/elseboundary. In bash,$?afterif … else …is 0 (theif's own exit). The actual push exit code is lost. This is the real problem — the comment will always saygit exit 0, not the real code.Let me confirm with a tiny shell sanity check.
Actually
$?does retain 42 here because the failed command (exit 42) was the last command executed in theelsebranch, before$?is read. Let me double-check the actual real-world sequence in the script:if git push …; then push_ok=1; else status=$?; …. Same pattern —$?is captured at the start of the else before any other command runs. That's fine, status will be the real push exit code. So item 3 is OK.Let me also verify the
[ -z "$url" ]second check is sound — what ifrespis a non-JSON Gitea error page and.html_urlresolves tonull, then theif type=="object"guard correctly falls back to the placeholder. Good.Now: heredoc/whitespace integrity check per learnings.
Branch head sha differs from the PR head sha returned by the API (
c4fb117b…vs0a06c813…) — that's just the branch having been force-updated after PR creation; the PR's head sha is whatmerge_baseuses for the diff. The diff I read above is the right one.One more correctness sanity check on the PR-failure message: when both
POST /pullsand the initialGET /pulls?state=openlookup miss,$respholds the POST response body (it was overwritten at line 374). The previousGETfailure detail is lost — the comment will show the POST error, which is fine and arguably the more informative one.Diff-stat and gating check (no new agent was added, so the agent-addition learnings don't apply here — but worth confirming diff-stat is otherwise sane):
Single file, exactly the two regions the issue called out, helpers/
🤖/fix-attempt template untouched, both⚠️comments now loud and clearly distinguish the failure,git pushno longer falls through to the "no changes" branch. Two minor nits below; nothing that should block.I write my review ON the PR thread, not on the issue — that's where the recommendations go.
PR #113 review (issues/PRs/113):
Both failure paths are now loud instead of silent. Helpers (
post,prpost,trig), the🤖loop-guardMARK, and the fix-attempt template+regex (lines 134/142) are untouched — diff confirmed clean againstmain.What this fix gets right:
git pushfailure now exits cleanly with a⚠️comment instead of falling through to the "no changes" branch (publish.sh:337-345). This is the silent-→-"nothing to do" misreport from the issue, gone.⚠️with the branch name (publish.sh:378-383) instead of the agent's plain reply with no signal.if type=="object" and .messageguard handles the case where Gitea returns a non-JSON / empty body gracefully.Minor nits (not blocking, but worth a one-liner fix if @junior has the branch open):
push_okis set on both branches of the newif/elseand never read anywhere → dead variable. Either drop it, or actually gate something on it (e.g. the subsequentgit fetchcould fail-fast).⚠️comment does NOT append$activity, but the PR-create-failure⚠️does (... $activity ...on line 381). Mild inconsistency — both error paths should probably include the activity log so a maintainer reading only the issue thread still sees the run summary.$status=$?immediately inside theelseclause does correctly capture the realgit pushexit code — I sanity-checked this in a subshell, it's not the bash-if-zeroes-$?footgun.Net: the requested fix is delivered correctly. Two small consistency polish items above, no correctness blockers.
details
🔧 43 tool calls · in 331964 · out 2687 tokens · subscription · model ollama-cloud/minimax-m3:cloud
🔧 skill:
Loaded skill: gitea-api🔧 bash:
echo "GITHUB_SERVER_URL=$GITHUB_SERVER_URL" && echo "GITHUB_REPOSITORY=$GITHUB_REPOSITORY"🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113" | jq '{title,state,body,head:.head.label,base:.base.label,user:.user.login,mergeable,created,updated}'🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113/files?limit=50" | jq '.[] | {filename, status, additions, deletions, changes, patch}'🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113/files?limit=50" > /tmp/opencode/pr113_files.json jq -r '.[0].raw' /tmp/opencode/pr113_files.json🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113" > /tmp/opencode/pr113.json jq '.patch' /tmp/opencode/pr113.json | head -200🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" -H "Accept: application/vnd.github.v3.diff" "$API/repos/gitea/agents/pulls/113" > /tmp/opencode/pr113.diff wc -l /tmp/opencode/pr113.diff head -300 /tmp/openco…🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113.diff" > /tmp/opencode/pr113.diff wc -l /tmp/opencode/pr113.diff cat /tmp/opencode/pr113.diff🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/contents/.gitea/workflows/scripts/publish.sh?ref=ai/issue-112" > /tmp/opencode/pub_pr.json jq -r '.content' /tmp/opencode/pub_pr.json …🔧 bash:
diff -u /tmp/opencode/publish_main.sh /tmp/opencode/publish_pr.sh🔧 bash:
grep -n "fix attempt" /tmp/opencode/publish_pr.sh /tmp/opencode/publish_main.sh echo "---" grep -n "🤖\|loop" /tmp/opencode/publish_pr.sh /tmp/opencode/publish_main.sh echo "---" grep -n "^post()\|^prpost()\|^trig()\|^post (" /tmp/opencode/p…🔧 read:
../../../tmp/opencode/publish_pr.sh🔧 bash:
grep -n "push_ok" /tmp/opencode/publish_pr.sh /tmp/opencode/publish_main.sh🔧 bash:
bash -c ' push_ok=0 if (exit 42); then push_ok=1 else status=$? echo "captured status=$status" fi '🔧 bash:
curl -sS -H "Authorization: token $SELF_TOKEN" "${GITHUB_SERVER_URL}/api/v1/repos/gitea/agents/branches" | jq '.[] | {name, sha: .commit.id}' | head -40🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113/files?limit=50" | jq 'map({filename, additions, deletions})'tokens — input 331964 (fresh 331964 · cache 0w / 0r) · output 2687 · reasoning 0 · subscription
The PR is already merged into main. Let me check the current state of the file on main, the commit log, and confirm everything looks correct after the review fix.
The fix has been merged into main, CI lint (syntax + shellcheck + YAML + agents.json schema) is green on the merge commit. Let me do one more sanity pass on the actual fix in the file.
Re-verification complete. The push-failure
postnow appends$activity(line 342), the PR-failure message puts$activityat the end instead of wedged between branch name and "Gitea message:" (line 382), andhttp_statusis captured via-w '%{http_code}'(line 371) and shown in both the echo and the posted message. The push-failurepostwas also updated to include$activityfor consistency with the PR-failurepost.push_okfrom the previous nit is gone — no more dead variable. Helpers (post/prpost/trig),🤖MARK, and the fix-attempt template+regex are still untouched. Lint (bash -n + shellcheck + YAML + agents.json schema) is green on the post-merge push.HALT_AUTOPILOTdetails
🔧 49 tool calls · in 659383 · out 3012 tokens · subscription · model ollama-cloud/minimax-m3:cloud
🔧 skill:
Loaded skill: gitea-api🔧 bash:
echo "GITHUB_SERVER_URL=$GITHUB_SERVER_URL" echo "GITHUB_REPOSITORY=$GITHUB_REPOSITORY"🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113" | jq '{title,state,body,head:.head.label,base:.base.label,user:.user.login,mergeable,created,updated}'🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113/files?limit=50" | jq 'map({filename, additions, deletions, changes, status})'🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113.diff" > /tmp/opencode/pr113.diff wc -l /tmp/opencode/pr113.diff cat /tmp/opencode/pr113.diff🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/contents/.gitea/workflows/scripts/publish.sh?ref=main" > /tmp/opencode/pub_main.json jq -r '.content' /tmp/opencode/pub_main.json | ba…🔧 bash:
grep -n "fix attempt\|🤖\|MARK\|post()\|prpost()\|trig()" /tmp/opencode/publish_pr.sh🔧 bash:
grep -n "push_ok" /tmp/opencode/publish_pr.sh /tmp/opencode/publish_main.sh🔧 bash:
diff -u /tmp/opencode/publish_main.sh /tmp/opencode/publish_pr.sh🔧 bash:
sha256sum /tmp/opencode/publish_main.sh /tmp/opencode/publish_pr.sh🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/contents/.gitea/workflows/scripts/publish.sh?ref=ai/issue-112" | jq -r '.sha' curl -sS -H "Authorization: token $SELF_TOKEN" "$API/rep…🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/branches" | jq '.[] | select(.name=="ai/issue-112" or .name=="main") | {name, sha: .commit.id}'🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/contents/.gitea/workflows/scripts/publish.sh?ref=main&ref=ai/issue-112" 2>&1 | head -5 echo "---" curl -sS -H "Authorization: token $S…🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" echo "=== Main ref: file sha ===" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/contents/.gitea/workflows/scripts/publish.sh?ref=main" | jq -r '.sha' echo "=== ai/issue-112 ref: fi…🔧 read:
../../../tmp/opencode/publish_pr.sh🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" echo "=== PR #113 status ===" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/pulls/113" | jq '{state, merged, merged_at, mergeable, base:.base.ref, head:.head.ref}' echo echo "=== I…🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" echo "=== Actions runs on main since the merge commit ===" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/actions/runs?limit=5" | jq '.workflow_runs[] | {id, name, status, conclusio…🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" echo "=== Run 1341 (push to main after the merge): jobs ===" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/actions/runs/1341/jobs" | jq '.[] | {name, status, conclusion}'🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/actions/runs/1341/jobs" | jq '.'🔧 bash:
API="${GITHUB_SERVER_URL}/api/v1" echo "=== Recent runs on the agent workflow / issue_comment events (look for any failure after merge) ===" curl -sS -H "Authorization: token $SELF_TOKEN" "$API/repos/gitea/agents/actions/runs?limit=15" | jq…🔧 read:
../../../tmp/opencode/publish_main.shtokens — input 659383 (fresh 659383 · cache 0w / 0r) · output 3012 · reasoning 0 · subscription