Felix FaerberandClaude Opus 5
c0e7b0f8a5
Docker / build (push) Successful in 19s
The build args were only in development-dependencies-env, which runs npm ci. npm run build happens in build-env, and args do not cross stages -- so Vite has never seen VITE_API_URL, VITE_GOOGLE_CLIENT_ID or VITE_COMMIT_SHA in any image this Dockerfile has produced. It went unnoticed because app/routes/*.tsx fall back to https://api.t4t-gateway.com, which is correct for the VPS image and silently wrong everywhere else: the homelab instance deployed today served a UI that called production, exactly what building it separately was meant to prevent. Verified from the served bundle -- assets/signup-*.js carried the VPS URL. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CYFnHida4AdiNDek2pzgXx
48 lines
1.4 KiB
Docker
48 lines
1.4 KiB
Docker
FROM public.ecr.aws/docker/library/node:20-alpine AS development-dependencies-env
|
|
|
|
ARG VITE_API_URL
|
|
ENV VITE_API_URL=$VITE_API_URL
|
|
|
|
ARG VITE_GOOGLE_CLIENT_ID
|
|
ENV VITE_GOOGLE_CLIENT_ID=$VITE_GOOGLE_CLIENT_ID
|
|
|
|
ARG VITE_COMMIT_SHA
|
|
ENV VITE_COMMIT_SHA=$VITE_COMMIT_SHA
|
|
|
|
COPY . /app
|
|
WORKDIR /app
|
|
RUN npm ci
|
|
|
|
FROM public.ecr.aws/docker/library/node:20-alpine AS production-dependencies-env
|
|
COPY ./package.json package-lock.json /app/
|
|
WORKDIR /app
|
|
RUN npm ci --omit=dev
|
|
|
|
FROM public.ecr.aws/docker/library/node:20-alpine AS build-env
|
|
|
|
# These have to be declared HERE, not only in development-dependencies-env:
|
|
# build args do not cross stages, and this is the stage that runs `npm run
|
|
# build`. Without them Vite inlines the fallbacks from app/routes/*.tsx --
|
|
# https://api.t4t-gateway.com -- so an image built for anywhere else silently
|
|
# drives production.
|
|
ARG VITE_API_URL
|
|
ENV VITE_API_URL=$VITE_API_URL
|
|
|
|
ARG VITE_GOOGLE_CLIENT_ID
|
|
ENV VITE_GOOGLE_CLIENT_ID=$VITE_GOOGLE_CLIENT_ID
|
|
|
|
ARG VITE_COMMIT_SHA
|
|
ENV VITE_COMMIT_SHA=$VITE_COMMIT_SHA
|
|
|
|
COPY . /app/
|
|
COPY --from=development-dependencies-env /app/node_modules /app/node_modules
|
|
WORKDIR /app
|
|
RUN npm run build
|
|
|
|
FROM public.ecr.aws/docker/library/node:20-alpine
|
|
COPY ./package.json package-lock.json /app/
|
|
COPY --from=production-dependencies-env /app/node_modules /app/node_modules
|
|
COPY --from=build-env /app/build /app/build
|
|
WORKDIR /app
|
|
CMD ["npm", "run", "start"]
|