gitea/agents
8
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

agents: fix ${SECRETS_JSON:-{}} brace bug (caller skills silently skipped) #68

Merged
ffaerber merged 1 commits from fix/caller-skills-brace-bug into main 2026-07-05 17:32:24 +02:00
Conversation 0 Commits 1 Files Changed 1
+6 -1
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e0ef954454 - Show all commits
.gitea/workflows/scripts/install-caller-skills.sh
+6 -1
View File
@@ -26,6 +26,8 @@
# decode them inside setup.sh. Single-line values mask correctly. # decode them inside setup.sh. Single-line values mask correctly.
set -eu set -eu
# Safe default for SECRETS_JSON (see note at the setup.sh call below re: the ${x:-{}} brace bug).
SJ="${SECRETS_JSON:-}"; [ -n "$SJ" ] || SJ='{}'
DIR="${WORKSPACE:-$GITHUB_WORKSPACE}/.gitea/agent-skills" DIR="${WORKSPACE:-$GITHUB_WORKSPACE}/.gitea/agent-skills"
CFG="$HOME/.config/opencode/opencode.json" CFG="$HOME/.config/opencode/opencode.json"
[ -d "$DIR" ] || { echo "no caller skills (.gitea/agent-skills/ absent) — nothing to install"; exit 0; } [ -d "$DIR" ] || { echo "no caller skills (.gitea/agent-skills/ absent) — nothing to install"; exit 0; }
@@ -48,9 +50,12 @@ for skill_dir in "$DIR"/*/; do
cp "$md" "$dest/SKILL.md" cp "$md" "$dest/SKILL.md"
chmod -R o=rX "$dest" chmod -R o=rX "$dest"
# Optional runtime setup, with all inherited secrets available as JSON (never printed here). # Optional runtime setup, with all inherited secrets available as JSON (never printed here).
# NOTE: pass SECRETS_JSON via a plain variable — do NOT inline ${SECRETS_JSON:-{}} here or in
# setup.sh: bash brace-matching appends a stray '}' when the var is set, corrupting the JSON so
# the skill's `jq` fails ("Unmatched '}'") and the skill is silently skipped.
if [ -f "$skill_dir/setup.sh" ]; then if [ -f "$skill_dir/setup.sh" ]; then
echo "caller skill '$name': running setup.sh for @$NAME" echo "caller skill '$name': running setup.sh for @$NAME"
SECRETS_JSON="${SECRETS_JSON:-{}}" NAME="$NAME" WORKSPACE="${WORKSPACE:-$GITHUB_WORKSPACE}" \ SECRETS_JSON="$SJ" NAME="$NAME" WORKSPACE="${WORKSPACE:-$GITHUB_WORKSPACE}" \
bash "$skill_dir/setup.sh" || { echo "caller skill '$name': setup.sh failed — skipping this skill"; continue; } bash "$skill_dir/setup.sh" || { echo "caller skill '$name': setup.sh failed — skipping this skill"; continue; }
fi fi
allow=$(jq -nc --argjson a "$allow" --arg n "$name" '$a + {($n):"allow"}') allow=$(jq -nc --argjson a "$allow" --arg n "$name" '$a + {($n):"allow"}')